From 17ccb205070362e01f6adcd8f0a25adf889e251f Mon Sep 17 00:00:00 2001 From: technillogue Date: Wed, 21 Jul 2021 15:35:26 -0400 Subject: [PATCH] catch NullPointerException instead of checking for null --- .../asamk/signal/json/JsonMessageEnvelope.java | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/main/java/org/asamk/signal/json/JsonMessageEnvelope.java b/src/main/java/org/asamk/signal/json/JsonMessageEnvelope.java index f66bed54..c5f7b818 100644 --- a/src/main/java/org/asamk/signal/json/JsonMessageEnvelope.java +++ b/src/main/java/org/asamk/signal/json/JsonMessageEnvelope.java @@ -67,17 +67,13 @@ public class JsonMessageEnvelope { this.sourceDevice = null; this.relay = null; } - if (this.source != null) { - String name; - try { - name = m.getContactOrProfileName(this.source); - } catch (InvalidNumberException e) { - name = null; - } - this.sourceName = name; - } else { - this.sourceName = null; + String name; + try { + name = m.getContactOrProfileName(this.source); + } catch (InvalidNumberException | NullPointerException e) { + name = null; } + this.sourceName = name; this.timestamp = envelope.getTimestamp(); if (envelope.isReceipt()) { this.receiptMessage = JsonReceiptMessage.deliveryReceipt(timestamp, List.of(timestamp));